Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting in CI #137

Closed
1 of 2 tasks
rwjblue opened this issue Apr 18, 2016 · 1 comment · Fixed by #214
Closed
1 of 2 tasks

Linting in CI #137

rwjblue opened this issue Apr 18, 2016 · 1 comment · Fixed by #214

Comments

@rwjblue
Copy link
Member

rwjblue commented Apr 18, 2016 •
edited
Loading

We need to ensure that new PR's do not introduce type issues, I see the path for this something like the following:

  • Add npm run vscode-build to .travis.yml's script (this will get at least a pass/fail for PR's until better testing can get setup).
  • Incorporate broccoli-tslinter to enable live reload style testing.
rwjblue added a commit that referenced this issue Apr 18, 2016
@rwjblue
Add linting to .travis.yml.
bd888ca 
Addresses one point from #137.
@rwjblue rwjblue mentioned this issue Apr 18, 2016
Closed
chancancode pushed a commit that referenced this issue Apr 18, 2016
@rwjblue @chancancode
Add linting to .travis.yml.
31a39a7 
Addresses one point from #137.
krisselden pushed a commit that referenced this issue Apr 20, 2016
@rwjblue @krisselden
Add linting to .travis.yml.
9071837 
Addresses one point from #137.
@GavinJoyce GavinJoyce mentioned this issue Jul 13, 2016
Merged
4 tasks
@GavinJoyce
Copy link
Contributor

GavinJoyce commented Jul 24, 2016 •
edited
Loading

This can be closed now (I forgot to add closes #xyz to the PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add tslinter
3 participants
@GavinJoyce @rwjblue @chadhietala