Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AttributeManager.setAttribute is megamorphic #338

Open
chadhietala opened this issue Oct 26, 2016 · 3 comments
Open

AttributeManager.setAttribute is megamorphic #338

chadhietala opened this issue Oct 26, 2016 · 3 comments

Comments

@chadhietala
Copy link
Member

No description provided.

@stefanpenner
Copy link
Contributor

@chadhietala do you mean this one https://github.com/tildeio/glimmer/blob/8409f1e8b6eae6ca323aea45ad0d69ab9d05e586/packages/glimmer-runtime/lib/dom/attribute-managers.ts#L72 ? Im not sure how to make it not megamorphic, as it will interact with a large number of different input types.

What did you have in mind?

@chadhietala
Copy link
Member Author

I agree. @krisselden mentioned this to me the other day on slack. I more or less created this issue because when Kris pings me with things I tend to believe they should be investigated 😄 .

@locks
Copy link
Contributor

locks commented Apr 18, 2020

Is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stefanpenner @locks @chadhietala