Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Windows Build Error #863

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Fixed Windows Build Error #863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build/symlink-dependencies/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ module.exports = {
if (isScopedPackage(dep)) { mkdirpScope(dep, modulesPath); }
fs.symlinkSync(
path.join('../../../../', dep),
path.join(modulesPath, dep)
path.join(modulesPath, dep),
'junction'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this conditional? In other words, do we have to detect the platform first and do one thing for windows and another for *nix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is ignored outside of Windows, and it passed CI so I would assume that makes it okay.

);
});
}
Expand Down
2 changes: 1 addition & 1 deletion testem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ let config = {
"disable_watching": true,
"launchers": {
"Node": {
"command": "./bin/run-node-tests.js",
"exe": "node", args: ["./bin/run-node-tests.js"],
"protocol": "tap"
}
},
Expand Down