Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the docs around node.js version #91

Merged
merged 1 commit into from
Jul 13, 2017
Merged

Updating the docs around node.js version #91

merged 1 commit into from
Jul 13, 2017

Conversation

twokul
Copy link
Contributor

@twokul twokul commented Jul 13, 2017

Currently, we support only node@6+ (mostly b/c of the way we wrote the blueprint). For example,

// ember-cli-build.js
const { GlimmerApp } = require('@glimmer/application-pipeline');

Destructuring is not supported in 4.

related to glimmerjs/glimmer-vm#579

@locks locks merged commit ea34136 into glimmerjs:master Jul 13, 2017
@twokul twokul deleted the patch-1 branch July 13, 2017 17:36
@rwjblue
Copy link
Member

rwjblue commented Jul 14, 2017

Hmm. We should probably make another issue to actually fix node@4 support. We do intend to follow the same policy as ember-cli itself RE: node support (which means all supported node LTS's and "current release").

@locks
Copy link
Collaborator

locks commented Jul 14, 2017

I was thinking the same but forgot to follow through 👍

@twokul
Copy link
Contributor Author

twokul commented Jul 14, 2017

@rwjblue I think it makes perfect sense but we don't want to alienate people b/c of wrong docs and it seemed like a quicker fix than to fix bluerprint

@rwjblue
Copy link
Member

rwjblue commented Jul 15, 2017

Ya, totally agree with the change here for the interim. I'm just saying we should also try to fix Node 4.

@locks
Copy link
Collaborator

locks commented Jul 15, 2017

See the referenced issue above ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants