Update blueprint to include tests/index.html. #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following is meant to satisfy the PR in glimmer application pipeline found here: glimmerjs/glimmer-application-pipeline#152 That PR takes the output from the `<glimmerAppRoot>/tests/index.html` and bundles it with the appropriate testEntryPoint in the dist after a build. (Sidenote: it does this in all non production environments rather than just test) In order for the process for new Glimmer apps to be smooth we need to utilize that PR (from glimmer application pipeline) and then also do the following (implemented in this PR): - Bump package version of glimmer-application-pipeilne (the assumption of this PR is that when we release glimmer-application-pipeline it will be bumped as a patch version to 0.11.3 - Add the default `tests/index.html` to the root of the project. This is what will be used by glimmer-application-pipeline - *note here* it uses a CDN url for QUnit because that is easier in a future PR we'll have glimmer-application-pipeline handle this such that it is available in the dist - Finally we must update the testem.json to point to `tests/index.html` which (as a result of how ember-cli works) is relative to the `dist` folder already. --- The benefits of this is that we can get a modern version of QUnit. Until this point new glimmer applications could only have 1 function that consumes the `hooks` per module which is stifling for a number of reasons. Furthermore, this PR (and its associated glimmer-application-pipeline PR) bring glimmer applications closer to the harness of Ember itself.
rwjblue
requested changes
Nov 5, 2018
| <head> | ||
| <meta charset="utf-8"> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <title>Glimmer PDP Viewer Tests</title> |
There was a problem hiding this comment.
Seems incorrect, probably should be <%= name %>
There was a problem hiding this comment.
Haha, quite right.
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
|
|
||
| <link rel="stylesheet" href="https://code.jquery.com/qunit/qunit-2.6.2.css"> | ||
| <script src="https://code.jquery.com/qunit/qunit-2.6.2.js"></script> |
There was a problem hiding this comment.
Lets go to 2.8.0 (for both this script and the styles above) 😸
rwjblue
approved these changes
Nov 5, 2018
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Edit from latest commit]
The following is meant to satisfy the PR in glimmer application pipeline
found here:
glimmerjs/glimmer-application-pipeline#152
That PR takes the output from the
<glimmerAppRoot>/tests/index.htmland bundles it with the appropriate testEntryPoint in the dist after a
build.
(Sidenote: it does this in all non production environments
rather than just test)
In order for the process for new Glimmer apps to be smooth we need to
utilize that PR (from glimmer application pipeline) and then also do the
following (implemented in this PR):
of this PR is that when we release glimmer-application-pipeline it will
be bumped as a patch version to 0.11.3
tests/index.htmlto the root of the project. Thisis what will be used by glimmer-application-pipeline
future PR we'll have glimmer-application-pipeline handle this such
that it is available in the dist
tests/index.htmlwhich (as a result of how ember-cli works) is relative to the
distfolder already.
The benefits of this is that we can get a modern version of QUnit.
Until this point new glimmer applications could only have 1 function
that consumes the
hooksper module which is stifling for a number ofreasons. Furthermore, this PR (and its associated
glimmer-application-pipeline PR) bring glimmer applications closer to
the harness of Ember itself.