Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update blueprint to include tests/index.html. #153

Merged
merged 4 commits into from
Nov 5, 2018
Merged

Update blueprint to include tests/index.html. #153

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a116fc2
Bump glimmer-application-pipeline dependency
rondale-sc Oct 22, 2018
bfd36d2
Implement testing concerns
rondale-sc Nov 3, 2018
48374be
Bump to final release version 0.13.0
rondale-sc Nov 5, 2018
04dfabc
Address review concerns
rondale-sc Nov 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@glimmer/blueprint/files/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"devDependencies": {
"@glimmer/application": "^0.12.0",
"@glimmer/application-pipeline": "^0.10.0",
"@glimmer/application-pipeline": "^0.13.0",
"@glimmer/blueprint": "~<%= blueprintVersion %>",
"@glimmer/component": "^0.12.0",
"@glimmer/inline-precompile": "^1.0.0",
Expand Down
4 changes: 1 addition & 3 deletions packages/@glimmer/blueprint/files/testem.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
{
"framework": "qunit",
"src_files": ["src/**/*"],
"serve_files": ["index.js"],
"test_page": "tests/index.html",
"disable_watching": true,
"launch_in_ci": ["Firefox", "Chrome"]
}
22 changes: 22 additions & 0 deletions packages/@glimmer/blueprint/files/tests/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<title>Glimmer PDP Viewer Tests</title>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems incorrect, probably should be <%= name %>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, quite right.

<meta name="description" content="">
<meta name="viewport" content="width=device-width, initial-scale=1">

<link rel="stylesheet" href="https://code.jquery.com/qunit/qunit-2.6.2.css">
<script src="https://code.jquery.com/qunit/qunit-2.6.2.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go to 2.8.0 (for both this script and the styles above) 😸

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

<script src="/testem.js"></script>
<script src="./index.js"></script>
</head>

<body>
<div id="qunit"></div>
<div id="qunit-fixture">
<div id="app"></div>
</div>
</body>
</html>