Fix type errors on ember canary #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Sep 10, 2021
NullVoxPopuli
commented
Sep 10, 2021
| @@ -1,5 +1,6 @@ | |||
| import { DEBUG } from '@glimmer/env'; | |||
| import { ComponentManager, ComponentCapabilities, TemplateArgs } from '@glimmer/core'; | |||
There was a problem hiding this comment.
TemplateArgs doesn't exist
There was a problem hiding this comment.
addon/-private/base-component-manager.ts:2:51 - error TS2305: Module '"../../../core/dist/commonjs"' has no exported member 'TemplateArgs'.
2 import { ComponentManager, ComponentCapabilities, TemplateArgs } from '@glimmer/core';
~~~~~~~~~~~~
There was a problem hiding this comment.
Take a look at #334, looks like this was just missed.
|
Blocked by #361 |
NullVoxPopuli
force-pushed
the
fix-type-errors-on-canary
branch
from
48fb529
to
e36580f
Compare
NullVoxPopuli
force-pushed
the
fix-type-errors-on-canary
branch
from
e36580f
to
b732c0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully improve the ember-beta and ember-canary CI