This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
Sync template compilation details with Ember, add @glimmer/babel-preset #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
sync-template-compilation-with-ember
branch
from
623c05f
to
7d87ecd
Compare
Syncs the details of template compilation with Ember so that both frameworks are using the same setup to compile templates. Also removes the two babel plugins in favor of a single babel preset. \## Breaking Changes - `createTemplate` has been renamed and updated to match `precompileTemplate` in Ember - `setComponentTemplate` and `createTemplateFactory` have been split apart into separate functions, matching the usage in Ember - `@glimmer/babel-plugin-glimmer-env` has been removed - `@glimmer/babel-plugin-strict-template-precompile` has been removed - `@glimmer/babel-preset` has been added - `@glimmer/debug` has been added with `deprecate` and `assert` functions
pzuraq
force-pushed
the
sync-template-compilation-with-ember
branch
from
7d87ecd
to
dce0cb6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncs the details of template compilation with Ember so that both
frameworks are using the same setup to compile templates. Also removes
the two babel plugins in favor of a single babel preset.
Breaking Changes
createTemplatehas been renamed and updated to matchprecompileTemplatein EmbersetComponentTemplateandcreateTemplateFactoryhave been splitapart into separate functions, matching the usage in Ember
@glimmer/babel-plugin-glimmer-envhas been removed@glimmer/babel-plugin-strict-template-precompilehas been removed@glimmer/babel-presethas been added@glimmer/debughas been added withdeprecateandassertfunctionsTemplateArgsinterface in favor of Arguments from@glimmer/interfaces