-
Notifications
You must be signed in to change notification settings - Fork 9
[Logs] console.trace calls show up as errors #37
Comments
@lostintangent, I'm a bit confused as to what the issue you're reporting is. Is it that this message isn't actually an "Error" but it being reported as such? |
That screenshot is showing the result of me calling |
Oh! I see, okay. Thanks for the clarification. |
See https://github.com/nodejs/node/blob/master/lib/console.js#L82_L90. |
Okay, it looks like the issue here is a difference in the implementation of the/a spec. The DevTools Working Group says that I do find Node's implementation to be a bit funny, but we should probably stick to their definition until we have a bit more user feedback. That said, calls to |
We can fairly easily proxy |
I like @mike-kaufman's suggestion, and think that we should make sure the Glimpse message has an |
|
Addressed with PR https://github.com/Glimpse/Glimpse.Node/pull/633. |
👌 I did find a related issue while testing this (https://github.com/Glimpse/Glimpse.Browser.Agent/issues/86), but this looks good. |
This is now available in Glimpse for Node 0.15.2. Please see our announcement issue for more information. |
This is a pretty minor issue, but since error messages display the red icon, it would be great if users could visually scan their logs for issues, without seeing any false negatives.
Repro steps:
console.trace
into your appLogs
tabExpected: To see the call to
console.trace
, displayed as an informational messageActual: The trace call shows up, but it is labeled as an error.
The text was updated successfully, but these errors were encountered: