Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deathlog button to better statistics screen #30

Closed
ItsProfessional opened this issue Sep 1, 2023 · 8 comments
Closed

Add deathlog button to better statistics screen #30

ItsProfessional opened this issue Sep 1, 2023 · 8 comments
Labels
status: wontfix this issue is confirmed, but will not be fixed type: compatibility this issue is caused by a compatibility problem

Comments

@ItsProfessional
Copy link

ItsProfessional commented Sep 1, 2023

Better Statistics Screen

@gliscowo
Copy link
Owner

While I appreciate that this is technically missing functionality, it would most likely make much more sense to be implemented on their side instead of DeathLog directly - you might want to consider opening an issue with them instead. Further, while the button is no doubt useful sometimes, it's not required as you can always open the screen using the provided keybind instead

Cheers

@gliscowo gliscowo closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2023
@gliscowo gliscowo added status: wontfix this issue is confirmed, but will not be fixed type: compatibility this issue is caused by a compatibility problem labels Sep 12, 2023
@ItsProfessional
Copy link
Author

While I appreciate that this is technically missing functionality, it would most likely make much more sense to be implemented on their side instead of DeathLog directly

Why? Better Statistics Screen is unrelated to deathlog. Them implementing support for tens or hundreds of mods doesn't make sense. It should be deathlog that adds support IMHO

@BasiqueEvangelist
Copy link

Why? Better Statistics Screen is unrelated to deathlog. Them implementing support for tens or hundreds of mods doesn't make sense. It should be deathlog that adds support IMHO

DeathLog also isn't related to Better Statistics Screen. Why should we have to add support for mods that literally entirely replace vanilla screens?

@ItsProfessional
Copy link
Author

Because deathlog adds to the screen. Better Statistics reimplements the screen. They don't have a reason to add non-vanilla things in their reimplementation. Mods that modify the vanilla screen should also modify the better statistics screen

@gliscowo
Copy link
Owner

And what if another mod comes around? Are we also supposed to modify the Better Statistics Screen Plus and Overhauled Statistics Screen 2024 edition? Tom's Amazing Statisics Viewer?

If a mod modifies vanilla behavior, it also becomes that mod's responsiblity to ensure other mods don't break. Either way this is a pointless discussion as DeathLog is still perfectly usable through the keybind

@ItsProfessional
Copy link
Author

Can you add it to the settings screen of the mod atleast? I really don't like adding unnecessary keybinds for opening mod screens

@Noaaan
Copy link

Noaaan commented Sep 12, 2023

Like any other keybind it should be present in the Controls screen

@ItsProfessional
Copy link
Author

ItsProfessional commented Sep 12, 2023

?????? that's not what I asked at all.
I asked him to add a button to open the deathlog screen in the settings screen when you open it in mod menu.
Not "how do I set a keybind?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wontfix this issue is confirmed, but will not be fixed type: compatibility this issue is caused by a compatibility problem
Projects
None yet
Development

No branches or pull requests

4 participants