Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have an option to disable the upcoming public search index #2358

Closed
ShadowJonathan opened this issue Aug 9, 2023 · 7 comments
Closed

Have an option to disable the upcoming public search index #2358

ShadowJonathan opened this issue Aug 9, 2023 · 7 comments

Comments

@ShadowJonathan
Copy link

Pitch

I would like to be able to disable public post search via environment variables, so that the elasticsearch instance will not index them.

Motivation

This is caused by me seeing this PR, which basically assures that mastodon soon will get a public search ability; mastodon#26344

I'd like to get ahead of that, and ask if it's possible to disable this via environment variables, like so many things already are configurable for glitch-soc

@old-adapdr
Copy link

Seems like a sane and necessary safety precaution to protect vulnerable users & communities, there is a huge difference in finding a person and easy (granular) access to that person's interactions. This should be reflected in via some form of settings.

@tobyink
Copy link

tobyink commented Aug 9, 2023

Don't want to bike shed too much, but environment variables seems a weird way to control this. Wouldn't a config file option or a setting available in the preferences screens make more sense?

@ShadowJonathan
Copy link
Author

AFAIK the environment variable file (.env.production) is pretty much the config file, unless there's another one I'm not aware of?

@tobyink
Copy link

tobyink commented Aug 9, 2023

There's config/environments/production.rb, config/settings.yml, and basically the entire config directory.

@ShadowJonathan
Copy link
Author

ShadowJonathan commented Aug 9, 2023

Ah, I just found mastodon#23808, which may be interesting to look at.

If that one is opt-in, and gets merged, then I consider this issue resolved.

@ClearlyClaire
Copy link

Upstream is going to use a separate, opt-in setting. I believe we can close this issue? It's not going to be per-post like mastodon#23808, but it's going to be opt-in either way.

@ShadowJonathan
Copy link
Author

Yeah, reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants