Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling web socket errors #38

Closed
trydis opened this issue Feb 4, 2018 · 4 comments
Closed

Handling web socket errors #38

trydis opened this issue Feb 4, 2018 · 4 comments

Comments

@trydis
Copy link

trydis commented Feb 4, 2018

Issue Overview

When looking at the code I'm wondering how to best handle web socket errors?

Here it throws an exception when a web socket error occurs.

If i'm not mistaking it will catch it here and log it without the library user being able to catch it?

If so, i guess the only way is to periodically compare ActiveWebSockets and AllSockets?

Package Version: 4.0.1

@glitch100
Copy link
Owner

Hi @trydis ,

We could add a callback in for errors if you would like, if they are getting swallowed by the underlying library?

@trydis
Copy link
Author

trydis commented Feb 6, 2018

I think that makes sense, especially since a connection is only valid for 24 hours.

A single connection to stream.binance.com is only valid for 24 hours; expect to be disconnected at the 24 hour mark

@glitch100
Copy link
Owner

Is this still required?

@trydis
Copy link
Author

trydis commented Jan 11, 2019

No, not by me at least.

@trydis trydis closed this as completed Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants