Text is removed when cancelling the open dialog

[gentleadam]

After opening the open dialog from the file menu and clicking close the text inputted in the text box disappears because the path cannot be found.

The open dialog needs to be handled better so that the text box only changes on a successful opening.

Get-Content : Cannot bind argument to parameter 'Path' because it is an empty string. At C:\Users\adam\Documents\GitHub\Personal\Jottey\Jottey.ps1:70 char:28 $InputData = Get-Content $global:InputFile CategoryInfo : InvalidData: (:) [Get-Content], ParameterBindingValidationException FullyQualifiedErrorId : ParameterArgumentValidationErrorEmptyStringNotAllowed,Microsoft.PowerShell.Commands.GetContentCommand

[gllms]

Yeah, that's some serious bug.
I see you've already been working on this: https://github.com/milkshakespoon/Jottey/commit/...
Is this working code?

[gentleadam]

Yeah, that's some serious bug.
I see you've already been working on this: https://github.com/milkshakespoon/Jottey/commit/...
Is this working code?

Trying to work on it... Although never used Windows forms before. It's kind of working, but not quite there. You might want to test it and see if you can make it better?

I am unable to work out where the file is saved by default when no file has been opened?

[gentleadam]

I think I've just fixed this. https://github.com/milkshakespoon/Jottey/commit/1e8e22697806ab5f00f2ee851ff940cd7c5bb73b

I'll let you have a test and then I can create a pull request if you're happy with the code. I'm learning as I'm going with this, so forgive me if my code is atrocious.

[gllms]

The file isn't saved when no file is opened 😳. It doesn't make sense indeed, you are unable to save your text you wrote before opening a file.
i've added an issue for it: #5

[gllms]

I'm sorry, but my computer is gone for a few days for maintenance, so I'm not able to test it right now.

[gentleadam]

The file isn't saved when no file is opened 😳. It doesn't make sense indeed, you are unable to save your text you wrote before opening a file.
i've added an issue for it: #5

Not quite sure what you're saying here. I noticed every time I restart Jottey the text file is wiped. I'm guessing because it doesn't attempt to open the last file you saved so overwrites it with no text as per the opening text box.

I'm sorry, but my computer is gone for a few days for maintenance, so I'm not able to test it right now.

No worries, continue to add issues and I'll see if I can fix them. Like you mentioned in Reddit, likely nobody really has a use for this text editor, but I want a small project to learn from.

[gllms]

Not quite sure what you're saying here. I noticed every time I restart Jottey the text file is wiped. I'm guessing because it doesn't attempt to open the last file you saved so overwrites it with no text as per the opening text box.

You already set the $global:InputFile. So when it autosaves, it saves the contents of the (empty) textbox to the filename you provided. I didn't set the variable at first, and Jottey also doesn't remember the last opened file, so nothing happens, because Jottey checks if the $global:InputFile is empty:

if ($global:InputFile -ne "") { 
  # If the filename not equals "", then...
  Set-Content $global:InputFile $TextBox.Text
}

[gentleadam]

Not quite sure what you're saying here. I noticed every time I restart Jottey the text file is wiped. I'm guessing because it doesn't attempt to open the last file you saved so overwrites it with no text as per the opening text box.

You already set the $global:InputFile. So when it autosaves, it saves the contents of the (empty) textbox to the filename you provided. I didn't set the variable at first, and Jottey also doesn't remember the last opened file, so nothing happens, because Jottey checks if the $global:InputFile is empty:

if ($global:InputFile -ne "") { 
  # If the filename not equals "", then...
  Set-Content $global:InputFile $TextBox.Text
}

Ah yes! I understand that now. I did set the path you're right. I wanted to test what would happen. However, despite having the path set Jottey always wipes the file and displays a blank text box. I don't think we have any code handling this?

[gllms]

Now we have.
My pc is back, btw.

[gentleadam]

Awesome! I thought I was going to submit a pull request. But all good.

[gllms]

We probably should assign each issue to a specific person to prevent confusion.

[gllms]

I thought I was going to submit a pull request.

I'm sorry. I got a bit over-enthusiastic after getting my pc back.

[gentleadam]

Yeah we can assign these tasks if you like. Might be nice. No worries. I've created a new pull request now, awaiting your auth.