Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field completeness script to Map UI #2297

Closed
joe-brilliant opened this issue Dec 4, 2021 · 8 comments
Closed

Add field completeness script to Map UI #2297

joe-brilliant opened this issue Dec 4, 2021 · 8 comments
Labels
P1: Launch blocker Needs fixing before we launch, schedule some time to investigate & fix React rebuild Visualizations
Milestone

Comments

@joe-brilliant
Copy link

Quick placeholder issue to incorporate @fojackson8's awesome new script to illustrate completeness % across all our db fields into our data viz when we roll out the new react rebuild for our map : ). This feature will help users get a snapshot of data completeness across our schema, which has been long requested

Will take some design thinking and tinkering but maybe it could live as an enhancement to our Coverage Map tab with some contextual options in the left-hand module to select different fields to view completeness by country.

image

@fojackson8 if you could add the CSV to this issue that would be great, thanks!

@joe-brilliant joe-brilliant added P1: Launch blocker Needs fixing before we launch, schedule some time to investigate & fix Visualizations React rebuild labels Dec 4, 2021
@joe-brilliant joe-brilliant added this to the Lewis milestone Dec 4, 2021
@maciej-zarzeczny maciej-zarzeczny moved this from To do to In progress in Global.health HTD Kanban Board Dec 13, 2021
@maciej-zarzeczny maciej-zarzeczny self-assigned this Dec 13, 2021
@fojackson8
Copy link
Contributor

@fojackson8
Copy link
Contributor

Please note the above CSV contains country completeness as calculated on 30/11/2021.
Completeness is defined as the percentage of non-empty rows in each column in the csv.

@joe-brilliant
Copy link
Author

Thanks @fojackson8 ! (see above @maciekz1996 )

@maciej-zarzeczny maciej-zarzeczny moved this from In progress to Internal PR (With WIP Label) in Global.health HTD Kanban Board Dec 17, 2021
@maciej-zarzeczny maciej-zarzeczny moved this from Internal PR (With WIP Label) to DONE in Global.health HTD Kanban Board Dec 22, 2021
@maciej-zarzeczny maciej-zarzeczny moved this from DONE to PR- For acceptance from BCH in Global.health HTD Kanban Board Dec 22, 2021
@joe-brilliant
Copy link
Author

joe-brilliant commented Jan 5, 2022

Following up email threads/chats today, would be great to add the equivalent of a "freshness" field that shows the latest date of ingestion per country (cc @fojackson8 @maciekz1996 @abhidg @jim-sheldon @iamleeg @Mougk)

@abhidg
Copy link
Contributor

abhidg commented Jan 6, 2022

Add completeness to aggregate code to generate JSON in covid-19-aggregates bucket

@marlenachroscicka marlenachroscicka moved this from PR- For acceptance from BCH to In progress in Global.health HTD Kanban Board Jan 19, 2022
abhidg added a commit that referenced this issue Jan 31, 2022
Related: #2297

Format of the new metrics/completeness.json is as follows

{
  "country1": {
    "field1": c1
    "field2": c2
  },
  "country2": {
  ...
  }
...
}

where c1 and c2 are the completeness (as a percentage) of the
respective fields.
abhidg added a commit that referenced this issue Jan 31, 2022
Related: #2297

Format of the new metrics/completeness.json is as follows

{
  "country1": {
    "field1": c1
    "field2": c2
  },
  "country2": {
  ...
  }
...
}

where c1 and c2 are the completeness (as a percentage) of the
respective fields.
abhidg added a commit that referenced this issue Feb 1, 2022
Related: #2297

Format of the new metrics/completeness.json is as follows

{
  "country1": {
    "field1": c1
    "field2": c2
  },
  "country2": {
  ...
  }
...
}

where c1 and c2 are the completeness (as a percentage) of the
respective fields.
@abhidg
Copy link
Contributor

abhidg commented Feb 1, 2022

@maciekz1996 Completeness data is at s3://covid-19-aggregates/metrics/completeness.json, let me know if you need any changes. The country labels will change to two letter codes once that migration is over. I have set the script to run weekly on Sundays.

@joe-brilliant
Copy link
Author

That's awesome thanks @abhidg! Does this also include "freshness"?

@maciej-zarzeczny maciej-zarzeczny moved this from In progress to Blockers in Global.health HTD Kanban Board Feb 1, 2022
@abhidg
Copy link
Contributor

abhidg commented Feb 1, 2022

@joe-brilliant freshness is at metrics/freshness.json updated daily

@joe-brilliant joe-brilliant modified the milestones: Lewis, Leonidas Feb 1, 2022
@maciej-zarzeczny maciej-zarzeczny moved this from Blockers to In progress in Global.health HTD Kanban Board Feb 2, 2022
@abhidg abhidg removed their assignment Feb 3, 2022
@maciej-zarzeczny maciej-zarzeczny moved this from In progress to Internal PR (With WIP Label) in Global.health HTD Kanban Board Feb 3, 2022
@maciej-zarzeczny maciej-zarzeczny moved this from Internal PR (With WIP Label) to DONE in Global.health HTD Kanban Board Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1: Launch blocker Needs fixing before we launch, schedule some time to investigate & fix React rebuild Visualizations
Development

No branches or pull requests

9 participants