fix for login page ready #2420
Merged
fix for login page ready #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciej-zarzeczny
suggested changes
Feb 4, 2022
There was a problem hiding this comment.
It looks way better on mobiles than before, good job 👍 While testing on iPhone X I saw that some text still spills out of the page, I think it would be best to put this "More information" section under first text block. Also 3 last images at the bottom of the page should be centered horizontally the same as images above.
| onClose: (value: boolean) => void; | ||
| message: string; | ||
| message: string | ReactNode; |
There was a problem hiding this comment.
What was the reason for this change?
There was a problem hiding this comment.
it is necessary to circumvent this error:
maciej-zarzeczny
approved these changes
Feb 8, 2022
abhidg
approved these changes
Feb 21, 2022
iamleeg
force-pushed
the
2390-text-spills-outside-screen
branch
from
79cb875
to
a1662cf
Compare
|
Just did the rebase with main: if CI passes then I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2297