-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location field does not support county-level lookup in the US. #426
Comments
Still waiting Jared's for this, he sent an email to their mapbox contact and we're awaiting a reply. |
Hey all! I haven't heard back from Mapbox. I have a follow-up email set to go out this afternoon if I still haven't heard back. |
Hi Jared, any update here, this is a key blocker for our first milestone |
They said: "Sounds like we do not currently have counties as a returnable data type in the US. If you have a counties layer then you could do a spatial join to extract that information for your current dataset." I know that Mapbox has county layer(s), and followed up asking if we can speak to an engineer on their recommended work around - but I haven't heard back yet. |
Mapbox says:
I've asked them if there is an existing Mapbox tileset for county (I believe there is), and am awaiting more info. They have confirmed that county is not returned for US, and I'm also waiting on some more clarity as to why that is the case. |
OK, I just had a nice talk with Mapbox. This sums it up:
I have the files she mentions - @sratcliffe118 who is best to take a look? Alternatively to using the Tilequery API, we could just use these shapefiles to do our own local lookup (for the US) to see what county any given point falls in. I'd imagine that would be straightforward. |
As a follow-up, if we feel that we really need Mapbox Boundaries (https://www.mapbox.com/boundaries/), lets regroup. We can definitely ask this of Mapbox, as long as we articulate why we need this product vs a the layer approach (either via mapbox or locally). |
@allysonjp715 is this something you can look at while Tim is out, or should we park this US requirement until Tim is back and pivot to some other countries. Note @axmb I don't see any reason not to test the bulk entry with ohio data but we will have to limit location to state and not county level Thoughts? |
Tim is the one who has been doing all the mapbox integration so he'd certainly be more familiar with it. Is 1.5 weeks too long to wait? I can take a deeper read into this tomorrow or Friday and see if I can pick it up. |
@allysonjp715 I think we are good to wait for Timothe to return, we can pivot to other geo's in the short term so we are not blocked |
@attwad Welcome back! |
Hmm so we're in the same position as when I left, we already had identified the counties in the tileset API but optimally we wouldn't have to do two queries (or even upload our own tileset!) that's quite frustrating... |
Thanks Tim! Please let me know if you need me to do anything. |
We have to account for the fact that no geocoder will have 100% recall (and no 100% precision either), so I made the Location part of the form editable: if the mapbox geocoder fails one can enter the location manually as it was done previously in the sheets system. Another way to do things when no results are given by the geocoder: one can also now try something in the vicinity and then fix the fields that are not exactly what they wanted them to be (name for example). I consider this bug fixed, there is still an open question of batch geocoding in #622 when no results are found. |
Location field does not support county-level lookup for the US.
This is a standard expectation to be able to enter the county (in the US) in which a case is occurring.
“In the United States, having county level data is critical”
The text was updated successfully, but these errors were encountered: