Make location display component form-ready #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is paving the way to making the fields editable in case mapbox doesn't have the full data or no data at all. Cf #572 #426
Plans for future PRs are to add an always-present suggestion to the places autocomplete that says "add my own geocode" that will populate an empty Location and make these fields editable.
We did lose the formatting of N/A when no data is present for some admin levels but it feels cleaner considering we want to allow curators to enter those manually now.
Also not rounding the lat/lng numbers anymore because they are used as input fields (they are still rounded in the display case component)