Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid interrupt inflight requests after a new socket connect failed #5

Merged
merged 2 commits into from
May 11, 2017

Conversation

domodwyer
Copy link

@domodwyer
Copy link
Author

Thanks @carter2000, much appreciated.

server.go Outdated
server.close(true)
}

func (server *mongoServer) close(idle bool) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

func (server *mongoServer) close(waitForIdle bool)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I have changed it as you suggest.

@@ -316,6 +320,19 @@ func (socket *mongoSocket) Close() {
socket.kill(errors.New("Closed explicitly"), false)
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

godoc?

@domodwyer domodwyer merged commit a34a648 into globalsign:development May 11, 2017
@domodwyer
Copy link
Author

Thanks @carter2000 - we'll be testing a build of this and then we'll merge it into master.

Cheers!

@domodwyer domodwyer mentioned this pull request May 15, 2017
@domodwyer domodwyer added the bug label Jul 26, 2017
babygoat added a commit to babygoat/go-api that referenced this pull request Jul 16, 2021
This patch updates the outdated mgo package to the community version
github.com/globalsign/mgo to fix the issue that the mgo session cannot
be used after the primary node shutdown and re-elected.

Related issue: globalsign/mgo#5
babygoat added a commit to babygoat/go-api that referenced this pull request Jul 16, 2021
This patch updates the outdated mgo package to the community version
github.com/globalsign/mgo to fix the issue that the mgo session cannot
be used after the primary node shutdown and re-elected.

Related issue: globalsign/mgo#5
babygoat added a commit to babygoat/go-api that referenced this pull request Jul 21, 2021
This patch updates the outdated mgo package to the community version
github.com/globalsign/mgo to fix the issue that the mgo session cannot
be used after the primary node shutdown and re-elected.

Related issue: globalsign/mgo#5
babygoat added a commit to babygoat/go-api that referenced this pull request Jul 21, 2021
This patch updates the outdated mgo package to the community version
github.com/globalsign/mgo to fix the issue that the mgo session cannot
be used after the primary node shutdown and re-elected.

Related issue: globalsign/mgo#5
libi pushed a commit to libi/mgo that referenced this pull request Dec 1, 2022
Avoid interrupt inflight requests after a new socket connect failed

Thanks to @carter2000
JosephYeh26 added a commit to JosephYeh26/go-twreport-api that referenced this pull request Apr 23, 2024
This patch updates the outdated mgo package to the community version
github.com/globalsign/mgo to fix the issue that the mgo session cannot
be used after the primary node shutdown and re-elected.

Related issue: globalsign/mgo#5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants