Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanobind port: Cluster module #1282

Merged
merged 9 commits into from
Sep 17, 2024
Merged

Nanobind port: Cluster module #1282

merged 9 commits into from
Sep 17, 2024

Conversation

tfteague
Copy link

@tfteague tfteague commented Sep 16, 2024

Description

Translate the Cluster module from cython to nanobind.

Motivation and Context

One component of the push to translate the freud from cython to nanobind.

How Has This Been Tested?

The cluster tests were not modified, but now all pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joaander joaander merged commit b370e8c into nanobind Sep 17, 2024
26 checks passed
@joaander joaander deleted the nanobind-cluster branch September 17, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants