Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Always show errors generated by NVRTC. Also, update to the latest
jitify.hpp
.Motivation and context
This helps users (and mailing list readers) identify errors in user patch code. Previously, users needed to recompile with
ENABLE_DEBUG_JIT=on
to see this information.ENABLE_DEBUG_JIT
still exists and adds additional details. This PR aims to cover the basic error information needed and show it only on error.Yes, we could manage our own fork of
jitify
and use it a submodule. However doing so would require 10x the effort of making these 3 lines of changes.How has this been tested?
I temporarily moved
warp_scan.cuh
, ran a test script that previously worked, and got this output:Change log
Checklist:
sphinx-doc/credits.rst
) in the pull request source branch.