Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table rendering of small numbers. #1617

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

b-butler
Copy link
Member

@b-butler b-butler commented Sep 7, 2023

Description

Fixes Table handling of small quantities by putting them in scientific notation.

Motivation and context

Despite not being recommended for data analysis, the table writer should output correct data.

Resolves #1542

How has this been tested?

Tests were added/modified to test handling of small numbers.

Change log

Fixed: `hoomd.write.Table`'s handling of small (less than one) numbers.

Checklist:

@b-butler b-butler requested review from a team, tcmoore3 and lyrivera and removed request for a team September 7, 2023 16:45
@joaander joaander added the validate Execute long running validation tests on pull requests label Sep 8, 2023
Copy link
Member

@tcmoore3 tcmoore3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joaander joaander merged commit df6075d into trunk-patch Sep 15, 2023
72 of 73 checks passed
@joaander joaander deleted the fix/table-small-quantities branch September 15, 2023 15:40
@joaander joaander mentioned this pull request Sep 25, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validate Execute long running validation tests on pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table logger logs small positive values incorrectly
3 participants