Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Local Snapshot Net Virial #1672

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Fix Local Snapshot Net Virial #1672

merged 1 commit into from
Dec 11, 2023

Conversation

b-butler
Copy link
Member

@b-butler b-butler commented Dec 8, 2023

Description

Switch strides from N, 6 to 6, GPUArray::getPitch.

Motivation and context

#1663

How has this been tested?

Existing tests pass plus test proposed in #1663 ran successfully.

Change log

Fixed: Access to net_virial in local snapshots.

Checklist:

@b-butler b-butler requested review from a team, joaander, tommy-waltmann and janbridley and removed request for a team December 8, 2023 20:49
@b-butler b-butler force-pushed the fix/local-snap-virials branch 2 times, most recently from a87db8f to a66585c Compare December 8, 2023 20:50
@b-butler
fix: The strides for LocalParticleData::getNetVirial
64b278f 
Switch from N, 6 to 6, GPUArray::getPitch.
@janbridley janbridley added the validate Execute long running validation tests on pull requests label Dec 9, 2023
janbridley
janbridley approved these changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@janbridley janbridley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

joaander
joaander approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joaander joaander merged commit 42e7317 into trunk-patch Dec 11, 2023
72 of 73 checks passed
@joaander joaander deleted the fix/local-snap-virials branch December 11, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaander joaander joaander approved these changes

@janbridley janbridley janbridley approved these changes

@tommy-waltmann tommy-waltmann Awaiting requested review from tommy-waltmann

Assignees
No one assigned
Labels
validate Execute long running validation tests on pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b-butler @joaander @janbridley