Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use integrated queries for searches instead of 'doc:' separation. #63

Closed
wants to merge 1 commit into from

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented May 19, 2019

Use integrated queries instead of doc: separation to search for jobs by state point and document.

Requires glotzerlab/signac#188 .

@csadorf csadorf requested review from bdice and a team as code owners May 19, 2019 22:44
@csadorf csadorf force-pushed the feature/integrated-queries branch from c7669b1 to 586aa9c Compare May 19, 2019 22:48
@csadorf
Copy link
Contributor Author

csadorf commented May 20, 2019

I guess the failing unit tests are to be expected since I broke backwards-compatibility. I'm going to wait for input from @bdice before proceeding.

@bdice
Copy link
Member

bdice commented May 23, 2019

@csadorf Thanks for this! Let's settle on an API for the signac PR before we deal with this. This PR would also change the version requirement of signac in its current state - perhaps there's a good fallback?

@csadorf
Copy link
Contributor Author

csadorf commented May 23, 2019

@csadorf Thanks for this! Let's settle on an API for the signac PR before we deal with this. This PR would also change the version requirement of signac in its current state - perhaps there's a good fallback?

I think we should be ok with an backwards-incompatible change here. After all, dashboard is in an early development stage.

@csadorf csadorf force-pushed the feature/integrated-queries branch from 586aa9c to 5e1a045 Compare May 23, 2019 13:34
@csadorf csadorf force-pushed the feature/integrated-queries branch from 5e1a045 to da7b35a Compare May 23, 2019 13:53
@vyasr
Copy link
Contributor

vyasr commented Nov 6, 2019

@bdice are you OK with closing this for now? We can reopen later, but as we're doing with other signac projects I think we should close PRs that are stalled until they're ready for review again (and we're stalled here because the corresponding signac PR is closed).

@bdice
Copy link
Member

bdice commented Nov 6, 2019

@vyasr, yes. Closing.

@bdice bdice closed this Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants