Skip to content

Commit

Permalink
Treat all warnings as errors (#871)
Browse files Browse the repository at this point in the history
* Make all warnings errors.

* Remove unnecessary warnings filter.

* Update changelog.
  • Loading branch information
vyasr committed Dec 8, 2022
1 parent 3e0ca40 commit 35b862f
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
1 change: 1 addition & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ Changed
- Detection of an invalid config will raise an error rather than a debug log (#855).
- The package namespace has been flattened so that most functionality is directly available in the ``signac`` namespace (#756, #868).
- The ``calc_id`` function has been moved from the ``hashing`` module to the ``job`` module (#873).
- Tests are run with all warnings treated as errors (#871).

Removed
+++++++
Expand Down
4 changes: 1 addition & 3 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ omit =

[tool:pytest]
xfail_strict = True
filterwarnings =
error::FutureWarning:signac.*
error::DeprecationWarning:signac.*
filterwarnings = error

[bumpversion:file:setup.py]

Expand Down
1 change: 0 additions & 1 deletion tests/test_sync.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,6 @@ def test_create_doc_dict_with_error_dryrun(self):
assert len(self.doc) == 0


@pytest.mark.filterwarnings("ignore::FutureWarning")
class TestFileModifyProxyJSONDocBackup(TestFileModifyProxyDocBackup):
@pytest.fixture(autouse=True)
def setUp(self, request):
Expand Down

0 comments on commit 35b862f

Please sign in to comment.