Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer _actors input into historical input keys #11957

Merged

Conversation

cedric-anne
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #11796

@cedric-anne cedric-anne self-assigned this Jun 21, 2022
@cconard96
Copy link
Contributor

Isn't the "Assign" action for actors in rules supposed to replace all previous actors of that type with the one specified?
Right now, Assign is acting the same as Append.

@AdrienClairembault
Copy link
Contributor

Isn't the "Assign" action for actors in rules supposed to replace all previous actors of that type with the one specified? Right now, Assign is acting the same as Append.

I've noticed the same behavior yesterday on GLPI 9.5 so It may be an old bug not related to @cedric-anne changes.
Still would be nice to fix it thought ;)

@cconard96 cconard96 mentioned this pull request Jun 23, 2022
2 tasks
@cedric-anne
Copy link
Member Author

I've noticed the same behavior yesterday on GLPI 9.5 so It may be an old bug not related to @cedric-anne changes.
Still would be nice to fix it thought ;)

assign only act on actors being added by current ticket update. If actors were already existing before the update process, they are not remove. We agreed, with @orthagh, to not change this behaviour for now.

@cedric-anne cedric-anne requested a review from btry June 24, 2022 14:38
@cedric-anne
Copy link
Member Author

There is some issues when using formcreator plugin. I have to investigate.

@cedric-anne cedric-anne marked this pull request as draft June 24, 2022 14:49
btry added a commit to btry/formcreator that referenced this pull request Jun 27, 2022
@cedric-anne
Copy link
Member Author

There is some issues when using formcreator plugin. I have to investigate.

Fixed in last commit.

@cedric-anne cedric-anne marked this pull request as ready for review June 27, 2022 06:59
btry added a commit to btry/formcreator that referenced this pull request Jun 27, 2022
btry added a commit to btry/formcreator that referenced this pull request Jun 27, 2022
btry added a commit to btry/formcreator that referenced this pull request Jun 27, 2022
btry added a commit to btry/formcreator that referenced this pull request Jun 27, 2022
btry added a commit to btry/formcreator that referenced this pull request Jun 27, 2022
btry added a commit to btry/formcreator that referenced this pull request Jun 27, 2022
btry added a commit to btry/formcreator that referenced this pull request Jun 27, 2022
@btry
Copy link
Contributor

btry commented Jun 27, 2022

The current state of the PR seems to work fine with he current revision support/2.13.0 of Formcreator. Anyway, I finished a PR in the plugin which cleans the actors before creating an ITIL object. (pluginsGLPI/formcreator#2857)

I thikn it is worth to merge as at least this plugin will no longer generate weird data and will no longer cause problem if there is need to upgrade the core.

@cedric-anne cedric-anne mentioned this pull request Jun 27, 2022
2 tasks
@cedric-anne cedric-anne merged commit bf955f2 into glpi-project:10.0/bugfixes Jun 27, 2022
@cedric-anne cedric-anne deleted the 10.0/fix-_actors-handling branch June 27, 2022 12:17
btry added a commit to pluginsGLPI/formcreator that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants