Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom asset cloning #16454

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Custom asset cloning #16454

merged 5 commits into from
Feb 6, 2024

Conversation

cconard96
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -

cedric-anne
cedric-anne requested changes Jan 29, 2024
View reviewed changes
src/Asset/Asset.php Show resolved Hide resolved
cedric-anne
cedric-anne reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests should be added on each capacity to check that cloning works as expected.

src/Asset/Capacity/AbstractCapacity.php Show resolved Hide resolved
@cconard96 cconard96 marked this pull request as ready for review January 30, 2024 20:49
@cedric-anne cedric-anne self-requested a review February 6, 2024 12:54
@cedric-anne cedric-anne added this to the 10.1.0 milestone Feb 6, 2024
@cedric-anne cedric-anne merged commit f7c6e59 into glpi-project:main Feb 6, 2024
8 checks passed
This was referenced Feb 7, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-anne cedric-anne cedric-anne approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cconard96 @cedric-anne