Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mbstring extension mandatory #16696

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

cedric-anne
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets see #16694

The symfony/polyfill-mbstring components only provides a partial implementation of the native mbstring extension. It will permit, for instance, to be able to correctly display the GLPI console (see #8331), but it will not be able to convert chars to the UTF7-IMAP encoding required by the mail collector. I propose to make this extension mandatory in future GLPI versions.

Related error:

glpiphplog.WARNING:   *** PHP Warning (2): iconv(): Wrong encoding, conversion from "UTF-8" to "UTF7-IMAP//IGNORE" is not allowed in /var/www/html/glpi/vendor/symfony/polyfill-mbstring/Mbstring.php at line 116
  Backtrace :
  vendor/symfony/polyfill-mbstring/Mbstring.php:116  iconv()
  ...or/symfony/polyfill-mbstring/bootstrap80.php:15 Symfony\Polyfill\Mbstring\Mbstring::mb_convert_encoding()
  src/MailCollector.php:1419                         mb_convert_encoding()
  src/MailCollector.php:707                          MailCollector->connect()
  src/MailCollector.php:1913                         MailCollector->collect()
  src/CronTask.php:1018                              MailCollector::cronMailgate()
  front/cron.php:84                                  CronTask::launch()

@cedric-anne cedric-anne added the dependencies Pull requests that update a dependency file label Mar 4, 2024
@cedric-anne cedric-anne added this to the 11.0.0 milestone Mar 4, 2024
@cedric-anne cedric-anne self-assigned this Mar 4, 2024
Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had in mind it was already required :D

@cedric-anne
Copy link
Member Author

I had in mind it was already required :D

It is marked as optional, so people may forget to enable it on CLI context.

@trasher
Copy link
Contributor

trasher commented Mar 4, 2024

I often do not have that in mind, since my linux distribution does not provide 2 php configs for cli and web :)

@cedric-anne cedric-anne merged commit ab52613 into glpi-project:main Mar 4, 2024
8 checks passed
@cedric-anne cedric-anne deleted the 11.0/mbstring branch March 4, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants