-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cartridge and Consumable Twig UI #17097
Cartridge and Consumable Twig UI #17097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't notice that issue because I didn't interact with the search results when I fixed the UI issue where they were appearing side-by-side. After all this work converting sublists to use the datatable template, this one case where it uses the full search results display with the controls feels very out of place. The "Queries log" tab for webhooks also uses the search result display but without controls so it fits in a little better. The intent for consumables to have the search engine display was to allow exporting the results and control which columns are shown, but none of the other lists have this same functionality. |
We may add flags to keep only the export part. |
Actually, it seems less about a fixed height and more that there is only one result so the table is short and the search dropdown has an absolute position so the z-index doesn't apply/work. |
761ac53
to
bdae7d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems technically OK.
Twig UI and cleanup of Cartridge and Consumable code.