Override native js functions window.alert and window.confirm

[orthagh]

(with identical behaviors)

For a prettier dialog :

[tomolimo]

Is there a possible title for the dialog?

[ghost]

why can't we like commits facebook-style ?

[ghost]

... ok i leave here

[tomolimo]

ah yes, I understand now :)

[ghost]

haha @tomolimo i was scared of a tomahawklimo to be sent :p

[tomolimo]

:)

[tomolimo]

???

[orthagh]

Here is the optional caption :

window.confirm('My confirm dialog', 'My title');

window.alert('My alert dialog', 'My title');

If not present, no title title is displayed for confirm.
For alert, "Information" by default (title is always present)

[tomolimo]

Perfect!

[orthagh]

I'll keep this pr unmerged until Friday.

Waiting for suggestions and improvments

[tomolimo]

ok

[tomolimo]

There is a problem as confirm() is asynchronous and works with the last clicked element....
If there is no clicked element this doesn't work in this case confirm returns immediately.
Those dialog boxes MUST be synchronous by definition.

[tomolimo]

I don't have time to fix this now, but I can do it on Monday

[orthagh]

Yes. Native confirm function is synchronous and new implementation is asynchronous (no solution for that, i spent 3hours to tests various code).
The idea was to retrigger click on last element to resend the confirm dialog and the value returned.

It absolutely can't work if you don't have a user stimuli (generally 'click').

I let you think and test a solution but i doubt it will be possible.
I think we need to remove all confirm functions from code and replace by a generic function do display a jquery dialog but with an asynchronous mode (with a click listener on affected element).

[tomolimo]

I'll check that on Monday.
I've got already some ideas.
Regards
Tomolimo

-------- Original message --------
From: Alexandre Delaunay
Date:22/01/2016 16:54 (GMT+01:00)
To: glpi-project/glpi
Cc: "Moron, Olivier"
Subject: Re: [glpi] Override native js functions window.alert and window.confirm (#380)

Yes. Native confirm function is synchronous and new implementation is asynchronous (no solution for that, i spent 3hours to tests various code).
The idea was to retrigger click on last element to resend the confirm dialog and the value returned.

It absolutely can't work if you don't have a user stimuli (generally 'click').

I let you think and test a solution but i doubt it will be possible.
I think we need to remove all confirm functions from code and replace by a generic function do display a jquery dialog but with an asynchronous mode (with a click listener on affected element).

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/380#issuecomment-173959813.

[tomolimo]

Questions: do we use Bootstrap?
and if we use it: which version of Bootstrap do we use in 0.91?

[orthagh]

No

[tomolimo]

At the end : can't changed asynch to synch :(