Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explaination of point 1.
Looks like the base purpose of the code commented with
// Clean DB
in transfer class was to clean the lines that were not valid (i.e. having a foreign key pointing to a wrong element).SELECT `glpi_documents_items`.`id`, `glpi_changes`.`id` FROM `glpi_documents_items` LEFT JOIN `glpi_changes` ON (`glpi_documents_items`.`items_id` = `glpi_changes`.`id` AND `glpi_documents_items`.`itemtype` = 'Change') WHERE `glpi_changes`.`id` IS NULL
will return a line with
`glpi_changes`.`id` => NULL
for all documents that are not linked to a Change.SELECT `glpi_documents_items`.`id`, `glpi_changes`.`id` FROM `glpi_documents_items` LEFT JOIN `glpi_changes` ON (`glpi_documents_items`.`items_id` = `glpi_changes`.`id`) WHERE `glpi_changes`.`id` IS NULL AND `glpi_documents_items`.`itemtype` = 'Change'
will return a line with
`glpi_changes`.`id` => NULL
for all documents that are linked to Change itemtype but with an id that does not correspond to a change.