[Modern UI] Video Lightbox #9296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orthagh
approved these changes
Jul 19, 2021
orthagh
pushed a commit
that referenced
this pull request
Jul 19, 2021
* Add video lightbox support * Fix missing controls * Fix deny dragging HTML content
cedric-anne
pushed a commit
that referenced
this pull request
Jul 22, 2021
* Add video lightbox support * Fix missing controls * Fix deny dragging HTML content
cedric-anne
pushed a commit
that referenced
this pull request
Jul 23, 2021
* Add video lightbox support * Fix missing controls * Fix deny dragging HTML content
cedric-anne
pushed a commit
that referenced
this pull request
Aug 4, 2021
* Add video lightbox support * Fix missing controls * Fix deny dragging HTML content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for screenshot plugin which has the ability to create and attach screen recordings directly from the ticket timeline. This will allow users and technicians to view these recordings directly from the timeline rather than forcing the user to download the video or having to open it in a new tab in order to view it.
Images and videos may be present in the same gallery.
Videos in the timeline have a placeholder "thumbnail" using
fas fa-video. I don't think having a proper thumbnail will be possible without a library likephp-ffmpeg.This PR also has a fix for having multiple galleries on the same page. Each gallery had the same id previously which caused issues at least with properly closing the gallery.