Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assert on meshes on byte_stride = 0 #205

Merged
merged 2 commits into from Feb 28, 2019
Merged

Fix assert on meshes on byte_stride = 0 #205

merged 2 commits into from Feb 28, 2019

Commits on Feb 24, 2019

  1. Add description to accessor stride assert

    @repi
    repi committed Feb 24, 2019
    Configuration menu
    Copy the full SHA
    04f62d6 View commit details
    Browse the repository at this point in the history

  2. Treat byte_stride = 0 same as no byte stride / tightly packed. 

    Have found glTF meshes (on Google Poly) that specify 0 byte stride for index buffers causing debug_assert to be triggered on 0 byte stride.

This should already fail validation, but only the case of validation_completely which is typically not run.

With this change we specifically handle the case of byte stride 0 and treat it as if no byte stride was specified to avoid the debug assert and panicking.
    @repi
    repi committed Feb 24, 2019
    Configuration menu
    Copy the full SHA
    8f29c6c View commit details
    Browse the repository at this point in the history