Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mono.Cecil 0.10 support #182

Closed
manu-st opened this issue Jan 31, 2017 · 14 comments
Closed

Mono.Cecil 0.10 support #182

manu-st opened this issue Jan 31, 2017 · 14 comments
Labels

Comments

@manu-st
Copy link

manu-st commented Jan 31, 2017

Hi,

Just wanted to know what was the status of using Mono.Cecil 0.10 in il-repack. I see there is a 0.10 branch, but it is not clear if it is up-to-date.

Thanks!

@gluck
Copy link
Owner

gluck commented Feb 13, 2017

The branch should be usable, save for debug (PDB/MDB) support, and more recent fixes (if any).
It's stiff missing that part to be merged into master though.

@xen2
Copy link
Contributor

xen2 commented Mar 10, 2017

Didn't look into it yet, but what's missing for PDB/MDB exactly? Isn't it automatically supported by Cecil?

@xen2
Copy link
Contributor

xen2 commented Mar 10, 2017

Update: found what needs to be done for PDB/MDB, investigating now.

@xen2
Copy link
Contributor

xen2 commented Mar 16, 2017

FYI, I have everything working in https://github.com/xen2/il-repack/tree/0.10

It currently needs https://github.com/xen2/cecil/tree/ilrepack (little bit temporary, until things get cleaned up and merged back in master)

Specifically, jbevain/cecil#351 and jbevain/cecil#353 will allow full Native PDB support alongside Portable PDB.

@xen2
Copy link
Contributor

xen2 commented Mar 16, 2017

Side note: I had weird problem with Baml (it was removing all extra assembly info, including from non merged types.
Fixed in this commit: xen2@8373370

@gluck
Copy link
Owner

gluck commented Mar 30, 2017

@xen2 your branch looks good, how are the symbols generated ? is it still native PDB or Portable ?

@xen2
Copy link
Contributor

xen2 commented Mar 30, 2017

It supports both of them.
New cecil added portable PDB and recently reworked and integrated my native PDB branch.

@SimonCropp
Copy link

@gluck any chance of this being pulled in any time soon?

@SimonCropp
Copy link

note that there were some upstream cecil pdb fixes recently
image

@tephe
Copy link
Contributor

tephe commented Jan 26, 2019

Any chance we could integrate cecil 0.10 on master? Looks like 0.10 was released as stable and 0.10.1 was already released

Thanks

@MaxXor
Copy link

MaxXor commented May 20, 2020

Any update on this? All bits for portable PDB support are added to Mono.Cecil.

@mattleibow
Copy link

Just bumping this thread here as portable pdbs are now the defaults.

@KirillOsenkov
Copy link
Collaborator

Our master branch is now using the very latest Cecil.

@MaxXor
Copy link

MaxXor commented Jan 2, 2024

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants