Pretasks #70
Merged
Pretasks #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabose
reviewed
May 15, 2019
| Name: gluster-ansible-roles | ||
| Version: 1.0.0 | ||
| Release: 2%{?dist} | ||
| Name: gluster-ansible |
There was a problem hiding this comment.
why is this part of pre-tasks change?
There was a problem hiding this comment.
This was a earlier commit which was done to do a build. And when the PR is created it included earlier commits as well.
| - name: Check if /var/log has enough disk space | ||
| shell: df -m /var/log | awk '/[0-9]%/ {print $4}' | ||
| register: disk_size | ||
| failed_when: disk_size.stdout|int < gluster_features_min_disk|default(15360) |
There was a problem hiding this comment.
are you changing the GiB to GB check here?
| when: gluster_infra_volume_groups is defined and | ||
| item.pvname is not search("/dev/mapper") and | ||
| gluster_features_512B_check|default(true) | ||
| with_items: "{{ gluster_infra_volume_groups }}" |
There was a problem hiding this comment.
can you also add assert statements to the task failures?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.