Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: overhaul glusterfs.spec(.in) to align with SUSE and Debian/Ubuntu packaging #1126

Closed
kalebskeithley opened this issue Mar 20, 2020 · 7 comments
Labels
Type:Bug wontfix Managed by stale[bot]

Comments

@kalebskeithley
Copy link
Contributor

kalebskeithley commented Mar 20, 2020

**Description of problem: **

Adopt common scheme for subpackages and their contents, e.g. each library is in its own subpackage, e.g. libglusterfs0...rpm, libgfapi0...rpm, libgfchangelog0...rpm, libgfxdr0....rpm. (corresponding -devel packages are libglusterfs-devel...rpm, etc.) FWIW, Ceph also follows this model in Fedora and RHEL, e.g. There might be other packages that follow this model in Fedora and RHEL too.

See https://github.com/gluster/glusterfs-suse/blob/leap15-glusterfs-7/glusterfs.spec for an example of what this would look like.

I would suggest preserving the python3-gluster, -client, and other sub-packages for finer grain installation, unlike, e.g. the SUSE example which does not have -client or python3-gluster subpackages.

For glusterfs-8!

The exact command to reproduce the issue:

The full output of the command that failed:

Expected results:

Additional info:

** - The output of the gluster volume info command**:

** - The operating system / glusterfs version**:

@kalebskeithley kalebskeithley changed the title packaging: overhaul glusterfs.spec(.in) in line with SUSE and Debian/Ubuntu packaging packaging: overhaul glusterfs.spec(.in) to align with SUSE and Debian/Ubuntu packaging Mar 20, 2020
@gluster-ant
Copy link
Collaborator

A patch https://review.gluster.org/24248 has been posted that references this issue.

packaging: refactor to align with best practices

Fixes: #1126

Change-Id: I7748c7531d52dedd71b3a7f5df049742258a6aba
Signed-off-by: Kaleb S. KEITHLEY kkeithle@redhat.com

@gluster-ant
Copy link
Collaborator

A patch https://review.gluster.org/24248 has been posted that references this issue.

packaging: refactor to align with best practices

Fixes: #1126

Change-Id: I7748c7531d52dedd71b3a7f5df049742258a6aba
Signed-off-by: Kaleb S. KEITHLEY kkeithle@redhat.com

@gluster-ant
Copy link
Collaborator

A patch https://review.gluster.org/24563 has been posted that references this issue.

packaging: refactor to align with common practices

Apparently some sdditional Obsoletes: are required

Change-Id: I919ae5a0fcc6f720e3eab4784af36977b9eef044
Fixes: #1126
Signed-off-by: Kaleb S. KEITHLEY kkeithle@redhat.com

@gluster-ant
Copy link
Collaborator

A patch https://review.gluster.org/24583 has been posted that references this issue.

packaging: refactor to align with common practices

The claim that Fedora package guidelines do not require this
scheme is a non-argument. Not only do they not require it, they
don't prohibit it either. (And you can't prove a negative. It's
a specious argument.)

Change-Id: I7748c7531d52dedd71b3a7f5df049742258a6aba
Fixes: #1126
Signed-off-by: Kaleb S. KEITHLEY kkeithle@redhat.com

@gluster-ant
Copy link
Collaborator

A patch https://review.gluster.org/24584 has been posted that references this issue.

packaging: refactor to align with common practices

Apparently some sdditional Obsoletes: are required

Change-Id: I919ae5a0fcc6f720e3eab4784af36977b9eef044
Fixes: #1126
Signed-off-by: Kaleb S. KEITHLEY kkeithle@redhat.com

gluster-ant pushed a commit that referenced this issue Jun 29, 2020
The claim that Fedora package guidelines do not require this
scheme is a non-argument. Not only do they not require it, they
don't prohibit it either. (And you can't prove a negative. It's
a specious argument.)

Change-Id: I7748c7531d52dedd71b3a7f5df049742258a6aba
Fixes: #1126
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
gluster-ant pushed a commit that referenced this issue Jun 29, 2020
Apparently some sdditional Obsoletes: are required

Change-Id: I919ae5a0fcc6f720e3eab4784af36977b9eef044
Fixes: #1126
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
@stale
Copy link

stale bot commented Jan 12, 2021

Thank you for your contributions.
Noticed that this issue is not having any activity in last ~6 months! We are marking this issue as stale because it has not had recent activity.
It will be closed in 2 weeks if no one responds with a comment here.

@stale stale bot added the wontfix Managed by stale[bot] label Jan 12, 2021
@stale
Copy link

stale bot commented Jan 27, 2021

Closing this issue as there was no update since my last update on issue. If this is an issue which is still valid, feel free to open it.

@stale stale bot closed this as completed Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug wontfix Managed by stale[bot]
Projects
None yet
Development

No branches or pull requests

3 participants