Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thin-arbiter integration with GD1 #687

Closed
aspandey opened this issue Jun 28, 2019 · 5 comments
Closed

Thin-arbiter integration with GD1 #687

aspandey opened this issue Jun 28, 2019 · 5 comments
Labels
DocApproved Mandatory flag to pass smoke. Provide user facing document to get approval. SpecApproved This is a mandatory flag for passing the smoke for feature. Provide spec of feature to get approval

Comments

@aspandey
Copy link
Member

Currently, thin arbiter volume can be created using GD2 only.
This issue will track the integration of thin arbiter volume with glusterd (glusterd1)

We should be able to create and manage thin-arbiter volume using glusterd.

@aspandey
Copy link
Member Author

@gluster-ant
Copy link
Collaborator

A patch https://review.gluster.org/22612 has been posted that references this issue.

glusterd/thin-arbiter: Thin-arbiter integration with GD1

gluster volume create replica 2 thin-arbiter 1 : :
: [force]

The changes have been made in a way that the last brick in the bricks list
will be treated as the thin-arbiter.
GD1 will be manipulated to consider replica count to be as 2 and continue creating the
volume like any other replica 2 volume but since thin-arbiter volumes need ta-brick
client xlator entries for each subvolume in fuse volfile, volfile generation is
modified in a way to inject these entries seperately in the volfile for every subvolume.

Few more additions -
1- Save the volinfo with new fields ta_bricks list and thin_arbiter_count.
2- Introduce a new option client.ta-brick-port to add remote-port to ta-brick xlator entry
in fuse volfiles. The option can be set using the following CLI syntax -
gluster volume set client.ta-brick-port <PORTNO.>
3- Volume Info will contain a Thin-Arbiter-path entry to distinguish
from other replicate volumes.

Change-Id: Ib434e2313b29716f32476c6c211d282c4ef39406
Updates #687
Signed-off-by: Vishal Pandey vpandey@redhat.com

@amarts amarts added SpecApproved This is a mandatory flag for passing the smoke for feature. Provide spec of feature to get approval DocApproved Mandatory flag to pass smoke. Provide user facing document to get approval. labels Jun 28, 2019
@amarts
Copy link
Member

amarts commented Jun 28, 2019

#352 is the original issue with details of the feature. This just describes how it is given to users with GD1

@gluster-ant
Copy link
Collaborator

A patch https://review.gluster.org/22612 has been posted that references this issue.

glusterd/thin-arbiter: Thin-arbiter integration with GD1

gluster volume create replica 2 thin-arbiter 1 : :
: [force]

The changes have been made in a way that the last brick in the bricks list
will be treated as the thin-arbiter.
GD1 will be manipulated to consider replica count to be as 2 and continue creating the
volume like any other replica 2 volume but since thin-arbiter volumes need ta-brick
client xlator entries for each subvolume in fuse volfile, volfile generation is
modified in a way to inject these entries seperately in the volfile for every subvolume.

Few more additions -
1- Save the volinfo with new fields ta_bricks list and thin_arbiter_count.
2- Introduce a new option client.ta-brick-port to add remote-port to ta-brick xlator entry
in fuse volfiles. The option can be set using the following CLI syntax -
gluster volume set client.ta-brick-port <PORTNO.>
3- Volume Info will contain a Thin-Arbiter-path entry to distinguish
from other replicate volumes.

Change-Id: Ib434e2313b29716f32476c6c211d282c4ef39406
Updates #687
Signed-off-by: Vishal Pandey vpandey@redhat.com

gluster-ant pushed a commit that referenced this issue Jun 28, 2019
gluster volume create <VOLNAME> replica 2 thin-arbiter 1 <host1>:<brick1> <host2>:<brick2>
<thin-arbiter-host>:<path-to-store-replica-id-file> [force]

The changes have been made in a way that the last brick in the bricks list
will be treated as the thin-arbiter.
GD1 will be manipulated to consider replica count to be as 2 and continue creating the
volume like any other replica 2 volume but since thin-arbiter volumes need ta-brick
client xlator entries for each subvolume in fuse volfile, volfile generation is
modified in a way to inject these entries seperately in the volfile for every subvolume.

Few more additions -
1- Save the volinfo with new fields ta_bricks list and thin_arbiter_count.
2- Introduce a new option client.ta-brick-port to add remote-port to ta-brick xlator entry
   in fuse volfiles. The option can be set using the following CLI syntax -
   gluster volume set <VOLNAME> client.ta-brick-port <PORTNO.>
3- Volume Info will contain a Thin-Arbiter-path entry to distinguish
   from other replicate volumes.

Change-Id: Ib434e2313b29716f32476c6c211d282c4ef39406
Updates #687
Signed-off-by: Vishal Pandey <vpandey@redhat.com>
@gluster-ant
Copy link
Collaborator

A patch https://review.gluster.org/22992 has been posted that references this issue.

glusterd/thin-arbiter: Thin-arbiter integration with GD1

gluster volume create replica 2 thin-arbiter 1 : :
: [force]

The changes have been made in a way that the last brick in the bricks list
will be treated as the thin-arbiter.
GD1 will be manipulated to consider replica count to be as 2 and continue creating the
volume like any other replica 2 volume but since thin-arbiter volumes need ta-brick
client xlator entries for each subvolume in fuse volfile, volfile generation is
modified in a way to inject these entries seperately in the volfile for every subvolume.

Few more additions -
1- Save the volinfo with new fields ta_bricks list and thin_arbiter_count.
2- Introduce a new option client.ta-brick-port to add remote-port to ta-brick xlator entry
in fuse volfiles. The option can be set using the following CLI syntax -
gluster volume set client.ta-brick-port <PORTNO.>
3- Volume Info will contain a Thin-Arbiter-path entry to distinguish
from other replicate volumes.

Change-Id: Ib434e2313b29716f32476c6c211d282c4ef39406
Updates #687
Signed-off-by: Vishal Pandey vpandey@redhat.com
(cherry picked from commit 9b223b1)

gluster-ant pushed a commit that referenced this issue Jul 5, 2019
gluster volume create <VOLNAME> replica 2 thin-arbiter 1 <host1>:<brick1> <host2>:<brick2>
<thin-arbiter-host>:<path-to-store-replica-id-file> [force]

The changes have been made in a way that the last brick in the bricks list
will be treated as the thin-arbiter.
GD1 will be manipulated to consider replica count to be as 2 and continue creating the
volume like any other replica 2 volume but since thin-arbiter volumes need ta-brick
client xlator entries for each subvolume in fuse volfile, volfile generation is
modified in a way to inject these entries seperately in the volfile for every subvolume.

Few more additions -
1- Save the volinfo with new fields ta_bricks list and thin_arbiter_count.
2- Introduce a new option client.ta-brick-port to add remote-port to ta-brick xlator entry
   in fuse volfiles. The option can be set using the following CLI syntax -
   gluster volume set <VOLNAME> client.ta-brick-port <PORTNO.>
3- Volume Info will contain a Thin-Arbiter-path entry to distinguish
   from other replicate volumes.

Change-Id: Ib434e2313b29716f32476c6c211d282c4ef39406
Updates #687
Signed-off-by: Vishal Pandey <vpandey@redhat.com>
(cherry picked from commit 9b223b1)
@amarts amarts closed this as completed Jul 8, 2019
Legogris added a commit to Legogris/glusterdocs that referenced this issue Feb 7, 2020
Since this is now in GD1, this should probably be removed? gluster/glusterfs#687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DocApproved Mandatory flag to pass smoke. Provide user facing document to get approval. SpecApproved This is a mandatory flag for passing the smoke for feature. Provide spec of feature to get approval
Projects
None yet
Development

No branches or pull requests

3 participants