Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide fallback for all parameters #50

Closed
yuriyz opened this issue Oct 31, 2016 · 3 comments
Closed

Provide fallback for all parameters #50

yuriyz opened this issue Oct 31, 2016 · 3 comments
Assignees
@yuriyz
Labels
enhancement
Milestone
4.2

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Oct 31, 2016

I noticed that the params here:
https://oxd.gluu.org/docs/oxdserver/#register-site

Do not match the config docs:
https://oxd.gluu.org/docs/conf#oxd-default-site-configjson
@yuriyz yuriyz self-assigned this Oct 31, 2016
@yuriyz yuriyz added this to the 3.1.0 milestone Mar 29, 2017
@yuriyz yuriyz modified the milestones: 3.2.0, 3.1.0 Jul 2, 2017
@yuriyz yuriyz modified the milestones: 3.1.2, 3.2.0 Nov 10, 2017
@yuriyz yuriyz modified the milestones: 4.0, 4.1 Jun 11, 2019
@duttarnab
Copy link
Collaborator

Do we need to add all request param of /register-site operation in defaultSiteConfig section (fallback configuration values) of oxd-server.yml. Please confirm.

@yuriyz
Copy link
Contributor Author

yuriyz commented Sep 23, 2019

Yes, correct.

duttarnab added a commit that referenced this issue Sep 26, 2019
@duttarnab
#50 - Provide fallback for all parameters
22f8345
duttarnab added a commit to GluuFederation/docs-oxd-prod that referenced this issue Sep 26, 2019
@duttarnab
#50 - Provide fallback for all parameters
43e6375 
#50 - Provide fallback for all parameters
GluuFederation/oxd#50
duttarnab added a commit to GluuFederation/docs-oxd-prod that referenced this issue Sep 26, 2019
@duttarnab
#50 - Provide fallback for all parameters
e5de8e1 
#50 - Provide fallback for all parameters
GluuFederation/oxd#50
This was referenced Sep 26, 2019
Merged
Merged
yuriyz added a commit that referenced this issue Sep 26, 2019
@yuriyz
Merge pull request #370 from GluuFederation/issue#50
b3a9ab9 
#50 - Provide fallback for all parameters
@yuriyz
Copy link
Contributor Author

yuriyz commented Sep 26, 2019

Done in #370

@yuriyz yuriyz closed this as completed Sep 26, 2019
@yuriyz yuriyz modified the milestones: 4.1, 4.2 Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
enhancement
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
2 participants
@yuriyz @duttarnab