Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try implementing the CA x509.Certificate constraints #10

Open
glvnst opened this issue May 17, 2020 · 0 comments
Open

try implementing the CA x509.Certificate constraints #10

glvnst opened this issue May 17, 2020 · 0 comments

Comments

@glvnst
Copy link
Owner

glvnst commented May 17, 2020

Upstream issue 26 has an interesting suggestion which could limit the blast radius of a file disclosure of the CA key. I suspect that generally file disclosure is a bit easier for an attacker to accomplish than full local compromise but I don't have anything to back that up.

I'd consider trying implementations of PermittedDNSDomains and PermittedIPRanges and just hooking PermittedDNSDomainsCritical to the presence of values in either.

x509.Certificate has these related fields:

    // Name constraints
    PermittedDNSDomainsCritical bool // if true then the name constraints are marked critical.
    PermittedDNSDomains         []string
    ExcludedDNSDomains          []string
    PermittedIPRanges           []*net.IPNet
    ExcludedIPRanges            []*net.IPNet
    PermittedEmailAddresses     []string
    ExcludedEmailAddresses      []string
    PermittedURIDomains         []string
    ExcludedURIDomains          []string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant