Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility of PTYTextView #123

Closed
wants to merge 8 commits into from

Conversation

@dusek
Copy link
Contributor

@dusek dusek commented Apr 7, 2013

Support VoiceOver, Zoom and ZoomText for Mac.

More details in individual commit messages. Main focus was
to get the visual bounds working properly, and while at it,
I fixed a few other small things as well.

dusek added 8 commits Apr 7, 2013
* the bounds must be returned in screen coordinates
* lines, as seen by VoiceOver, are visual lines,
  i.e. softlines. Adjust _allText to respect that when computing the
  linebreak offsets, which also fixes the visual bounds for cases
  where softlines occur
Now when moving through characters/words with VoiceOver, the visual
bounds of VoiceOver cursor match exactly
Now Zoom users (System Preferences > Accessibility > Zoom) enjoy Zoom
following the iTerm2 cursor so that it always stays in the magnified
portion of the screen.

Unfortunately this does not work with ZoomText for Mac as it uses the
accessibility methods (accessibilityAttributeValue*) which seem to not
provide accurate information (more specifically,
lineBreak{Char,Index}Offsets_ are nil - when VoiceOver is running,
they are not and ZoomText for Mac works fine).
@gnachman
Copy link
Owner

@gnachman gnachman commented Apr 16, 2013

Thanks for the patch! Merged.

@gnachman gnachman closed this Apr 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants