Fix accessibility of PTYTextView #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the bounds must be returned in screen coordinates * lines, as seen by VoiceOver, are visual lines, i.e. softlines. Adjust _allText to respect that when computing the linebreak offsets, which also fixes the visual bounds for cases where softlines occur
Now when moving through characters/words with VoiceOver, the visual bounds of VoiceOver cursor match exactly
Now Zoom users (System Preferences > Accessibility > Zoom) enjoy Zoom
following the iTerm2 cursor so that it always stays in the magnified
portion of the screen.
Unfortunately this does not work with ZoomText for Mac as it uses the
accessibility methods (accessibilityAttributeValue*) which seem to not
provide accurate information (more specifically,
lineBreak{Char,Index}Offsets_ are nil - when VoiceOver is running,
they are not and ZoomText for Mac works fine).
|
Thanks for the patch! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support VoiceOver, Zoom and ZoomText for Mac.
More details in individual commit messages. Main focus was
to get the visual bounds working properly, and while at it,
I fixed a few other small things as well.