Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some feedbacks #12

Closed
Adafede opened this issue Jan 9, 2022 · 2 comments
Closed

some feedbacks #12

Adafede opened this issue Jan 9, 2022 · 2 comments

Comments

@Adafede
Copy link

Adafede commented Jan 9, 2022

Hi, I tested quickly your tool and here is what I can say:

  • Installation works fine
  • Commands are clear and consistent with other GNtools
  • Adding headers to csv/tsv format would be nice (found them via -f pretty)
  • The family column in the output is quite cryptic for external users, a brief description in the README would probably help.
  • The error message FATA[0000] the CSV file needs `scientifiName` field contains typos
  • Globally, very nice even if I don't see applications at the moment on my side, adding somehow a more straightforward way for the user to do gnfinder and then gndiff on files might open possibilities. I am sure you already had this in mind but I see this combination as very powerful in the future.

Your work is amazing and useful to so many people out there!

@dimus dimus closed this as completed in 2b8d2f7 Jan 9, 2022
@dimus
Copy link
Member

dimus commented Jan 9, 2022

Thanks a lot @Adafede for your feedback and the typo fix! I made fixes that you suggested. The header was already fixed in #10, just did not percolate to a release yet, will be there soon.

@Adafede
Copy link
Author

Adafede commented Jan 10, 2022

Superfast as always!

I might have still not fully understood it, but regarding the family column I meant the one in the output... I have plenty of id clean and family cleanassociated with the referenceRecords ... and nothing if the fields are not clean? Is this expected? What does this id clean and family clean mean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants