Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty error messages in browser console #9

Closed
armikhalev opened this issue Aug 22, 2018 · 3 comments
Closed

Empty error messages in browser console #9

armikhalev opened this issue Aug 22, 2018 · 3 comments
Assignees
Milestone

Comments

@armikhalev
Copy link

Description :octocat:

Empty Ghostwheel error message appears in browser console.

Reproduction guide 馃

Following the ReadMe:

  • add [gnl/ghostwheel "0.2.3"] to project.clj (using Figwheel).
  • add #:ghostwheel.core{:check true, :num-tests 10} to the namespace.
  • add the following code taken from the ReadMe:
(>defn addition
  [a b]
  [pos-int? pos-int? => int? | #(> % a) #(> % b)]
  (+ a b))
  • add (ghostwheel/check) at the end of the file.

Observed behaviour: 馃憖 馃挃
ghostwheel-no-error
(NOTE: foo and ranged-rand also from the docs, I just don't add them here)

Expected behaviour: 鉂わ笍 馃槃
no-error
(NOTE: Disregard the number of checks, it's just a pic from the ReadMe)

@armikhalev
Copy link
Author

armikhalev commented Aug 22, 2018

Apparently the issue is caused by presence of [org.clojure/test.check "0.9.0"] in project.clj. Removing it solves the problem!

@gnl
Copy link
Owner

gnl commented Aug 23, 2018

Thank you Arseny, the problem here is that there were some breaking changes in [org.clojure/test.check "0.10.0-alpha3"] and after integrating that version in the last Ghostwheel release, it no longer works with an older one.

I'll add a note to the documentation that people should be careful not to override Ghostwheel's dependencies in their project.cljs.

@gnl gnl self-assigned this Aug 23, 2018
@gnl gnl added this to the 0.2.4 milestone Aug 26, 2018
@gnl
Copy link
Owner

gnl commented Dec 1, 2018

Added note to the documentation.

@gnl gnl closed this as completed Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants