-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
failed to require macro-ns "playback.core", it was required by "playback.core", RuntimeException: No such var: server/as-channel #2
Comments
My guess would be that Portal's reference to Can you check for that and try to create a minimal repro, maybe with a very basic Hello World or template project that uses the same Shadow config, see if you can make it break and then start removing dependencies until it works and you find the culprit. |
I found the culprit for compilation error - [figwheel-sidecar "0.5.19"]. After removing it, exception goes away. Thanks for the advice! I think you should add 2 points to the Quick Start guide: 1. org.clojure/clojurescript and org.clojure/clojure dependencies must be explicitly added to the project.Without this, running a shadow-cljs project results in the following:
2. Browsers might block Portal as a pop-up window.I missed this at first, and thought that playback wasn't working properly. |
Glad it's working!
It's generally understood and implicitly assumed that people will manually add Clojure and ClojureScript as their most essential project dependencies; we don't automatically do this in libraries, because it risks overriding someone's chosen version in unpredictable ways. I will however add a note about the required Clojure version being 1.10+.
That's a good point, I'll add a hint, thanks. I'll leave this issue open until I've updated the README. |
I just updated the README. One final clarifying note on why this happened exactly – usually an older version of a dependency wouldn't automatically override a newer one when using tools.deps, however the older version of http-kit required by figwheel-sidecar uses the simple name |
Tried to add playback to my project as instructed. Removed Debux and explicitly added:
Still, I'm getting the error:
full-error.txt
shadow-cljs.txt
The text was updated successfully, but these errors were encountered: