Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chain] Add JSON output support for gnoland secrets get #2301

Closed
zivkovicmilos opened this issue Jun 7, 2024 · 3 comments · Fixed by #2393
Closed

[chain] Add JSON output support for gnoland secrets get #2301

zivkovicmilos opened this issue Jun 7, 2024 · 3 comments · Fixed by #2393
Assignees
@zivkovicmilos
Milestone
🏗4️⃣ test4.gno.land

Comments

@zivkovicmilos
Copy link
Member

Description

This task concerns adding a JSON output support to gnoland secrets get, and laying out a foundation for this sort of functionality in other commands (JSON + regular text output).

Related #2249
@zivkovicmilos zivkovicmilos self-assigned this Jun 7, 2024
@Kouteki Kouteki mentioned this issue Jun 7, 2024
Open
@linhpn99
Copy link
Contributor

linhpn99 commented Jun 7, 2024 •
edited
Loading

#2249
Can I extend the PR to solve the problem you are mentioning ?
But how about gnoland secrets get, How are we classifying it ?

@zivkovicmilos zivkovicmilos mentioned this issue Jun 12, 2024
Closed
@zivkovicmilos
Copy link
Member Author

Hey @linhpn99, I'd much rather keep this as a separate PR. I'll tackle it, no worries 👍

@Kouteki Kouteki assigned ajnavarro and unassigned zivkovicmilos Jun 14, 2024
This was referenced Jun 15, 2024
Merged
Closed
@zivkovicmilos
Copy link
Member Author

@linhpn99

We have the PR out in #2363

zivkovicmilos added a commit that referenced this issue Jun 19, 2024
@zivkovicmilos
feat: add support for displaying the P2P Address for node secrets info (
6032b48 
#2361)

## Description

Closes #1922 

This PR introduces a new section to the `Node P2P Info` secrets output,
that displays the P2P connection address.
The secrets fetch command remains unchanged, and this info can be
displayed by calling `gnoland secrets get NodeKey`

It displays the following values:
- if the config is not initialized yet, the default p2p listen address
is used
- if the config is initialized, the p2p listen address value is used

<img width="842" alt="Screenshot 2024-06-19 at 10 59 48"
src="https://github.com/gnolang/gno/assets/16712663/217a80b9-2c46-444b-8b80-62a80ecdea4d">

These values will be easily fetch-able when we introduce json output
support for these outputs in #2301

cc @mazzy89 

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
@zivkovicmilos zivkovicmilos linked a pull request Jun 19, 2024 that will close this issue
feat: overhaul gnoland secrets and gnoland config to output JSON #2393
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zivkovicmilos zivkovicmilos

Labels
None yet
Projects
🧙‍♂️gno.land core team
Status: Done
Milestone
🏗4️⃣ test4.gno.land
3 participants
@ajnavarro @zivkovicmilos @linhpn99