-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gnokey): JSON-ify the query results from the 'gnokey' query #2249
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2249 +/- ##
==========================================
- Coverage 54.68% 54.65% -0.03%
==========================================
Files 583 584 +1
Lines 78503 78570 +67
==========================================
+ Hits 42930 42946 +16
- Misses 32364 32416 +52
+ Partials 3209 3208 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this. The default output for vm/qeval
should be simple and human-readable; JSON is helpful for working with scripting but harms readability. Ie. I want the result of vm/qeval
to be simple to understand and close to what I get reading the result of maketx call
.
I suggest having a -output
flag, defaulting to text
, but which can be set to json
, for the gnokey query
, maketx -broadcast
and broadcast
commands. This should print the JSON response from the node, with little modification. In the case of qeval
, this can be simply qres.Response
.
… into format-query-response
… into format-query-response
agree with u, so that i will also format response when calling maketx --broadcast. |
From issue of @leohhhn : #2232
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description