fix: [gnoweb] fix unset binding #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
github-actions
bot
added
the
📦 ⛰️ gno.land
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1446 +/- ##
==========================================
+ Coverage 56.28% 56.30% +0.01%
==========================================
Files 422 422
Lines 65699 65699
==========================================
+ Hits 36980 36991 +11
+ Misses 25835 25824 -11
Partials 2884 2884 ☔ View full report in Codecov by Sentry. |
moul
approved these changes
Dec 16, 2023
thehowl
pushed a commit
that referenced
this pull request
Dec 21, 2023
Before:  After:  Continues #1446 --- Flag parsing was broken because `fs.Parse` was expecting to use `os.Args[1:]` instead of `os.Args`. I fixed it, simplified the implementation and added a regression test. --------- Signed-off-by: moul <94029+moul@users.noreply.github.com>
gfanton
added a commit
to moul/gno
that referenced
this pull request
Jan 18, 2024
gfanton
pushed a commit
to moul/gno
that referenced
this pull request
Jan 18, 2024
Before:  After:  Continues gnolang#1446 --- Flag parsing was broken because `fs.Parse` was expecting to use `os.Args[1:]` instead of `os.Args`. I fixed it, simplified the implementation and added a regression test. --------- Signed-off-by: moul <94029+moul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix empty binding on gnoweb, was a lefthover of #1386 that didn't take the correct flags into account
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description