-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: repair gnoweb flag parsing #1476
Conversation
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1476 +/- ##
==========================================
+ Coverage 55.87% 56.09% +0.21%
==========================================
Files 430 432 +2
Lines 65618 65898 +280
==========================================
+ Hits 36667 36968 +301
+ Misses 26083 26045 -38
- Partials 2868 2885 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
Before: ![CleanShot 2023-12-21 at 00 31 36@2x](https://github.com/gnolang/gno/assets/94029/9587d366-adac-42a1-9527-0b14c97ff89f) After: ![CleanShot 2023-12-21 at 00 59 08@2x](https://github.com/gnolang/gno/assets/94029/8560bf0c-a145-47a5-b456-80f38479f390) Continues gnolang#1446 --- Flag parsing was broken because `fs.Parse` was expecting to use `os.Args[1:]` instead of `os.Args`. I fixed it, simplified the implementation and added a regression test. --------- Signed-off-by: moul <94029+moul@users.noreply.github.com>
Before:
After:
Continues #1446
Flag parsing was broken because
fs.Parse
was expecting to useos.Args[1:]
instead ofos.Args
. I fixed it, simplified the implementation and added a regression test.