feat(cmd/gno): move test output within gno code #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehowl
requested review from
jaekwon,
piux2,
moul and
harry-hov
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1594 +/- ##
==========================================
+ Coverage 55.80% 56.13% +0.33%
==========================================
Files 436 438 +2
Lines 66168 66163 -5
==========================================
+ Hits 36922 37143 +221
+ Misses 26356 26127 -229
- Partials 2890 2893 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thehowl
changed the title
|
before/after clumsy asciicast: |
ajnavarro
approved these changes
Jan 29, 2024
harry-hov
approved these changes
Jan 31, 2024
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
Feb 2, 2024
Once again, welcome to "I was annoyed by a small thing that I wanted to do a 10 minute fix for and ended up on a refactoring detour". This PR moves the output of the `gno test` function to happen within the gno code. This solves a number of issues: - filtered tests are no longer printed to the console with `--- FILT` (my original 10-minute fix) - test output is no longer buffered - success of subtests is reported correctly - run/success report of subtests goes to stderr instead of stdout - `--- FAIL` is not printed for every time a Fail function is called (ie. only once) - as a bonus, `SkipNow` and `FailNow` actually work, so now you can Skip and Fatal your way out of test functions. Fixes gnolang#665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once again, welcome to "I was annoyed by a small thing that I wanted to do a 10 minute fix for and ended up on a refactoring detour".
This PR moves the output of the
gno testfunction to happen within the gno code. This solves a number of issues:--- FILT(my original 10-minute fix)--- FAILis not printed for every time a Fail function is called (ie. only once)SkipNowandFailNowactually work, so now you can Skip and Fatal your way out of test functions.Fixes #665