chore(gnoclient): modify Run to use baseTxCfg & multiple MsgRun args
#1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1637 +/- ##
==========================================
- Coverage 56.57% 56.24% -0.33%
==========================================
Files 439 439
Lines 66618 66242 -376
==========================================
- Hits 37688 37258 -430
- Misses 26013 26095 +82
+ Partials 2917 2889 -28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I see that you added me as a reviewer. To review, I'll wait until CI errors are fixed and the PR is not Draft. 😁 |
thehowl
reviewed
Feb 8, 2024
leohhhn
requested review from
a team,
jaekwon,
piux2 and
harry-hov
as code owners
leohhhn
force-pushed
the
chore/basetx-msgrun
branch
from
ac82701
to
e74cac5
Compare
7 tasks
jefft0
approved these changes
Feb 14, 2024
thehowl
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
LGTM; ping @zivkovicmilos / @gfanton for second review/merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the Gnoclient
Runmethod implement multipleMsgRunargs, and use the preexistingbaseTxCfgstruct. It also introduces unit & integration tests (basis for which was @jefft0's code in a previous PR), optimizes Call & Run code as per comment, and fixes a bug in code and in previous tests found along the way.Another, separate PR will be made to add even more tests for
gnoclient.Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description