fix(gnovm): correct type for shift expression #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terface_comparison
ltzmaxwell
changed the title
ltzmaxwell
changed the title
|
Hi @thehowl , this one is good to review too. |
deelawn
requested changes
Aug 6, 2024
There was a problem hiding this comment.
Nice work. I think there are a few things that need fixing. I appreciate all of the tests. The Go spec has a some nice cases that maybe we could also include as part of the tests: https://arc.net/l/quote/offplfsv
ltzmaxwell
commented
Aug 8, 2024
deelawn
approved these changes
Aug 12, 2024
piux2
reviewed
Aug 18, 2024
| @@ -7,4 +7,4 @@ func main() { | |||
| } | |||
|
|
|||
| // Error: | |||
| // main/files/types/shift_a11.gno:3:1: cannot convert StringKind to UintKind | |||
| // main/files/types/shift_a11.gno:5:7: invalid operation: invalid shift count: (const ("hello" <untyped> string)) | |||
There was a problem hiding this comment.
the original error message seems correct.
| @@ -6,4 +6,4 @@ func main() { | |||
| } | |||
|
|
|||
| // Error: | |||
| // main/files/types/shift_a7.gno:3:1: cannot convert StringKind to UintKind | |||
| // main/files/types/shift_a7.gno:5:10: invalid operation: invalid shift count: (const ("a" <untyped> string)) | |||
There was a problem hiding this comment.
the original error message seems correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: this one is ready for review.
shift operator where first operand is an untyped bigint always results in a bigint is not resolved by #1426, it's fixed by this one.
=================================================================