test(bug): In TestDeleteByAddress, delete by address, check deletion of all keys with that address

[jefft0]

This PR demonstrates a bug. In keybase_test, we add a new test TestDeleteByAddress which is similar to the existing TestKeyManagement. We use CreateAccount to add two accounts with the same mnemonic (same bech32 address) but two different names, "john" and "john2". Then we call Delete to delete by the bech32 address. Only one of the keys is deleted. The other still exists.

To run the test:

cd gno/tm2/pkg/crypto/keys
go test .

Expected: pass. Actual: The test fails with:

        	Error Trace:	/Users/jefft0/work/gno/gno/tm2/pkg/crypto/keys/keybase_test.go:150
        	Error:      	Should be false
        	Test:       	TestDeleteByAddress

Discussion: Keybase writeInfo stores the same info under the key name and also the key address. This only allows an address to map to one name. When the key (with the same address) is created by the second name, the mapping from the address to the first name is replaced. Therefore, the call to delete by address only deletes the entry by the second name. The key is still accessible by the first name, meaning that "delete" doesn't really delete.

Possible solutions:

• writeInfo should fail if there is already an entry for the address, or
• writeInfo should map an address to a set of key names, or
• don't "double index" by both name and address. (Only by name.)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.70%. Comparing base (e282618) to head (416ea5d).
Report is 180 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2476   +/-   ##
=======================================
  Coverage   54.70%   54.70%           
=======================================
  Files         583      583           
  Lines       78504    78504           
=======================================
  Hits        42945    42945           
  Misses      32350    32350           
  Partials     3209     3209           

Flag	Coverage Δ
contribs/gnodev	23.81% <ø> (ø)
contribs/gnofaucet	14.46% <ø> (ø)
contribs/gnokeykc	0.00% <ø> (ø)
contribs/gnomd	0.00% <ø> (ø)
gno.land	62.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jefft0]

I added the "bug" label so that this PR gets attention as demonstrating a bug.